-
Notifications
You must be signed in to change notification settings - Fork 113
PVA access permissions info #3506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+342
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ChannelSearch.runSearches` used to re-use one `to_search` array list. By the time the submitted searches encode the channels from that list, it might get cleared and re-populated. Need to create a new one in each `runSearches` call. At same time removed some unnecessary casts.
Lower default EPICS_PVA_MAX_ARRAY_FORMATTING
removeClient already includes unregisterSubscription
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to Channel Access, PV Access so far lacked access permissions info. A client like an operator display cannot show that a PV is read-only. Users would only notice that a PV is actually read-only when writing and then receiving an error.
A protocol update has been proposed and discussed with PVXS developers, epics-docs/epics-docs#140 It has not been implemented in PVXS, yet, but this implementation in java provides a preview of what it would look like. It is fully compatible with PVXS, the new PVA protocol message is simply ignored.
It allows https://github.com/controlSystemStudio/pvaify to mirror the write permissions from the CA client side to the PVA server side and then see the result in CS-Studio displays.
./serverdemo
creates PVs "demo" (read-only) and "demo3" (writable).A display with
pva://demo
andpva://demo3
will reflect write access or lack thereof:With the corresponding pva_acl branch of pvaify, a demo database and access config can dynamically change write permissions and the display will then update its widgets to allow or block write access.